{{ message }}
chore: modernize ngx (CI trigger, flake refresh, treefmt.toml cleanup)#5
Merged
Conversation
…treefmt.toml - ci.yml: trigger push CI on `main` (the default branch), not `master`. The branch never existed here, so push CI had never run and the spago 1.x migration went unverified. - flake.lock: bump pslua to current main (319831d) and nixpkgs to 2026-06-16. - remove treefmt.toml, superseded by treefmt.nix (`nix fmt`).
There was a problem hiding this comment.
Pull request overview
Modernizes the repo’s Nix/CI setup so that the post–Spago 1.x state is actually exercised by GitHub Actions, and removes obsolete treefmt configuration now handled by treefmt.nix/nix fmt.
Changes:
- Fix GitHub Actions push CI trigger to run on
maininstead ofmaster. - Refresh flake inputs by updating
flake.lock(notablypsluaandnixpkgs). - Remove
treefmt.tomlnow that formatting is configured viatreefmt.nix/treefmt-nix.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings purescript-lua-ngx up to the current ecosystem baseline and gets its CI actually running.
The spago 1.x migration (commit 1316ee5) landed on
main, but the push CI trigger was still set tomaster, a branch this repo never had. So push CI had never run and the migration stayed unverified. This points the trigger atmain, and the build is confirmed locally.Changes:
main, notmaster.nix fmt) replaced.Verified locally in the dev shell:
./scripts/buildproduces both dist modules, luacheck is clean (0 warnings, 0 errors), andnix fmtleaves the tree unchanged. The PR's own CI run is the first push/PR CI this repo has executed since the migration.