ensure Gen seed is modified after resize by matthewleon · Pull Request #88 · purescript/purescript-quickcheck · GitHub
Skip to content

ensure Gen seed is modified after resize#88

Merged
garyb merged 1 commit into
purescript:masterfrom
matthewleon:resize-state
Feb 26, 2018
Merged

ensure Gen seed is modified after resize#88
garyb merged 1 commit into
purescript:masterfrom
matthewleon:resize-state

Conversation

@matthewleon

Copy link
Copy Markdown
Contributor

see purescript/purescript-gen#12 (comment)

@safareli you might want to give this a quick check (totally accidental pun) to see if I've missed anything.

@safareli safareli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garyb

garyb commented Feb 26, 2018

Copy link
Copy Markdown
Member

@matthewleon

Copy link
Copy Markdown
Contributor Author

A minor thing, but this could probably be written nicely in terms of state.

Cool, I'll give it a shot.

@matthewleon

Copy link
Copy Markdown
Contributor Author

@garyb that is indeed much more elegant. Should be good now.

@garyb garyb merged commit ba48265 into purescript:master Feb 26, 2018
@garyb

garyb commented Feb 26, 2018

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants