{{ message }}
Modularised Prelude#41
Closed
garyb wants to merge 1 commit into
Closed
Conversation
Member
Author
There was a problem hiding this comment.
Yep! You need to import qualified _ as _ though, import _ as _ doesn't work which perhaps should be added too.
Contributor
|
👍 Looks nice. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is not for merging just yet, as this formulation has some changes that will have impact elsewhere:
The following modules are currently defined in
purescript-controlbut sans the actual classes. I've merged them in here, so I guess if we did this we'd want to remove them fromcontrol? Either that or reverse the dependency andPreludewould become something more like an even more minimalbase.Data.FunctorControl.ApplyControl.ApplicativeControl.BindControl.MonadIt seems like
Data.Functorshould belong in-functorsnow we have it, but that's not a great option without some work and dependency shuffling - it depends ontuplesandfoldable-traversable.Other breaking changes we talked about:
returnalias forpure(++)alias forappendSome we didn't discuss, but seem worth considering:
liftM1to justliftM. I guess if we were going to include higher arity versions then keeping the 1 would make sense alternatively.lift2...lift5functions toliftAnto make them less ambiguous and to matchliftA1.whenandunlessintoControl.Applicativeand relaxed theMonadconstraint toApplicative.Some non-breaking changes/enhancements:
Controlmodule exports itsControldependencies, so if you importApplicativethen you getFunctorand associated operators in scope too.(X b) => X (a -> b)as we had them on some classes and not others currentlyThere's a lot of stuff here, maybe we don't want any of it - that's fine, it was mainly to pass some time while on the road 😄