{{ message }}
Repository navigation
Bundle and optimize - #2111
Closed
jutaro wants to merge 22 commits into
Closed
Bundle and optimize#2111jutaro wants to merge 22 commits into
jutaro wants to merge 22 commits into
Conversation
…dOptimize # Conflicts: # src/Language/PureScript/Bundle.hs # src/Language/PureScript/BundleOpt.hs # src/Language/PureScript/BundleTypes.hs
Contributor
|
|
||
| -- * Call replacement | ||
|
|
||
| -- | replace satured calls to calls to uncurried functions |
Contributor
|
Also, can we have some tests, please? Perhaps write some programs, compile them both with and without the uncurry optimization, and verify that they behave in the same way? |
|
|
||
| shouldUncurry :: Parser String | ||
| shouldUncurry = strOption $ | ||
| short 'p' |
Contributor
There was a problem hiding this comment.
psc currently has one option for turning each individual optimization on or off, --no-tco, --no-magic-do, with no short version so perhaps we should follow suit here? --[no-]optimize-uncurry?
Contributor
|
Thanks for the PR! I'll spend some time reviewing this during the week. |
Closed
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue Uncurry optimization #479. Here's the read-up: http://symbolian.net/2016/04/07/513