{{ message }}
feat: add secrets#385
Open
miekg wants to merge 7 commits into
Open
Conversation
This adds (limited) support for secrets. In the end we wont to support the new 'secrets engine' from docker, but this still requires secrets to be put in a container. This piggybacks on configs as much as possible to make the PR as small as possible. We use /run/secrets to store them this is a tmpfs so nothing lands on disk. If a container path is used, we symlink that to /run/secrets, so only a symlink lands on disk, not the secret it self. When storing the container in corrosion we use base64 encryption, see the TODO there to do proper encrytion. Update the compatiblity matrix to say we have limited support for secrets. See: psviderski#75 and possibly psviderski#76 Note for psviderski#76, we will def. want to use the secrets engine of docker: https://github.com/docker/secrets-engine Signed-off-by: Miek Gieben <miek@miek.nl> b64 encode secrets before storing Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
it also prefixes /run/secrets, no need to do it here Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds (limited) support for secrets. In the end we want to support the new 'secrets engine' from docker, but this still requires secrets to be put in a container.
This piggybacks on configs as much as possible to make the PR as small as possible.
We use /run/secrets to store them this is a tmpfs so nothing lands on disk.
If a container path is used, we symlink that to /run/secrets, so only a symlink lands on disk, not the secret it self.
When storing the container in corrosion we use base64 encryption, see the TODO there to do proper encrytion.
Update the compatiblity matrix to say we have limited support for secrets.
See: #75 and possibly #76
Note for #76, we will def. want to use the secrets engine of docker: https://github.com/docker/secrets-engine