{{ message }}
Fix: #222. Support custom registry for MetricsHandler.#223
Merged
brian-brazil merged 1 commit intoDec 13, 2017
Merged
Conversation
Pass a registry to start_http_server via a MetricsHandler
factory implemented as a staticmethod of the existing class.
Contributor
Contributor
Author
|
I split the patch in two. This is just the custom registry part. No multiprocess. |
Contributor
|
Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Add
registryparameter to start_http_server, so you can serve datafrom a custom registry.
How it's implemented
Added:
registrytostart_http_serverregistryvia MetricHandler.factoryHow do you use it
Create a new or a multiprocess registry
Pass
registry=myregistryto start_http_server.