Treat tab as text, not whitespace by eemeli · Pull Request #606 · projectfluent/fluent.js · GitHub
Skip to content

Treat tab as text, not whitespace#606

Merged
eemeli merged 1 commit into
projectfluent:masterfrom
eemeli:tab-is-text
Feb 9, 2023
Merged

Treat tab as text, not whitespace#606
eemeli merged 1 commit into
projectfluent:masterfrom
eemeli:tab-is-text

Conversation

@eemeli

@eemeli eemeli commented Feb 8, 2023

Copy link
Copy Markdown
Member

See projectfluent/python-fluent#173

Tabs were defined to be text, not whitespace, in projectfluent/fluent#167, but this change was not reflected in the trailing whitespace trimming that was added in #247.

@eemeli eemeli requested a review from gregtatum February 8, 2023 15:56

@gregtatum gregtatum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eemeli eemeli merged commit a6ccb2d into projectfluent:master Feb 9, 2023
@eemeli eemeli deleted the tab-is-text branch February 9, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants