{{ message }}
Implement Syntax 0.9#342
Merged
Merged
Conversation
stasm
force-pushed
the
impl-zero-nine
branch
from
0fd83b7 to
fcec241
Compare
stasm
commented
Feb 19, 2019
Contributor
Author
There was a problem hiding this comment.
I kept args here rather then renaming them to arguments because:
- We have custom logic in
behavior_test.jsto compare these comments. - Behavior tests are going away in Remove behavior tests #304 anyways.
Contributor
Author
There was a problem hiding this comment.
I'll file a spec issue on this.
stasm
requested review from
Pike and
zbraniecki
and removed request for
zbraniecki
zbraniecki
approved these changes
Feb 19, 2019
zbraniecki
left a comment
zbraniecki
left a comment
Collaborator
There was a problem hiding this comment.
That looks great! One comment but nothing blocking. Congrats Stas! :)
zbraniecki
reviewed
Feb 21, 2019
Pike
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/projectfluent/fluent/projects/6