Syntax Compatibility Strategy document by stasm · Pull Request #251 · projectfluent/fluent · GitHub
Skip to content

Syntax Compatibility Strategy document#251

Merged
stasm merged 4 commits into
projectfluent:masterfrom
stasm:compat-strategy
Apr 17, 2019
Merged

Syntax Compatibility Strategy document#251
stasm merged 4 commits into
projectfluent:masterfrom
stasm:compat-strategy

Conversation

@stasm

@stasm stasm commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

This document is based on my conversations with @flodolo and @Pike. The goal is to document the compatibility strategy for introducing and removing syntax features.

@stasm stasm requested review from Pike and flodolo April 8, 2019 10:59

@flodolo flodolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, but in general it looks good to me.

Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md Outdated
@stasm stasm force-pushed the compat-strategy branch from 1fd7be3 to 92a1e25 Compare April 15, 2019 13:59
@stasm stasm requested a review from Pike April 15, 2019 14:02

@Pike Pike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

I have one more general thought, but not pressing right now: Should we be explicit about not allowing insta-break changes? I can see people wondering "Dude, I can also just break stuff, what's then?", might be good to make that explicit?

The only other thing I found was that it'd be nice to backport the changes you made to post 1.x at the bottom to the introduction part. I took a stab at that, feel free to put something else in there. Nothing blocking.

Comment thread spec/compatibility.md Outdated
Comment thread spec/compatibility.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the em dash here. I could go with spaces around it, but I know that's debated spelling.

@stasm

stasm commented Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

@stasm stasm merged commit dc373ec into projectfluent:master Apr 17, 2019
@stasm stasm deleted the compat-strategy branch April 17, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants