{{ message }}
Revert changes to NumberLiteral from #232#242
Merged
Conversation
This was referenced Feb 21, 2019
Contributor
Author
Contributor
|
Yeah, that might help, but would that make rebasing #246 hard? |
stasm
force-pushed
the
number-literal
branch
from
f1c3f68 to
7f43cf6
Compare
stasm
changed the title
Contributor
Author
|
I intended to rebase/squash #246 anyways, and it wasn't hard at all :) |
Contributor
Author
Pike
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #239. Revert changes from #232 which made
valuebe a float, and addedprecision. Also renamevaluetorawfor consistency withStringLiteral. I'll file another issue to discuss removing unescaping from the AST and moving it into the resolver.