{{ message }}
Add parameterized Attributes#212
Merged
Merged
Conversation
stasm
force-pushed
the
attr-params
branch
2 times, most recently
from
881d8fc to
0bbd3dd
Compare
Contributor
Author
Pike
approved these changes
Nov 14, 2018
Pike
left a comment
Pike
left a comment
Contributor
There was a problem hiding this comment.
r=me, this looks much better, thanks.
I think there's a left-over validation for AttributeExpression? Doesn't hurt, but I'd remove it.
Also, as a follow-up, do you want to update valid.md to the changes here, too?
Neither blocking.
Contributor
There was a problem hiding this comment.
I think this part is not needed with the reduced changes after the rebase? Attributes are always on messages or terms still.
Contributor
Author
There was a problem hiding this comment.
You're right, but I'd like to keep this here for the sake of completeness. I think it complements the validation of CallExpression. Let's keep it for now and I'll see if I can remove it in a follow-up.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #189. Add syntax to allow expressions of the form
-term.attr(arg: "value"), e.g.: