Allow all Unicode characters by stasm · Pull Request #207 · projectfluent/fluent · GitHub
Skip to content

Allow all Unicode characters#207

Merged
stasm merged 4 commits into
projectfluent:masterfrom
stasm:any-unicode-char
Nov 9, 2018
Merged

Allow all Unicode characters#207
stasm merged 4 commits into
projectfluent:masterfrom
stasm:any-unicode-char

Conversation

@stasm

@stasm stasm commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

Fix #182, but differently. An alternative to #199.

@Pike Pike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the test fix, and some reference to recommendations.md in grammar.mjs.

Comment thread test/fixtures/any_char.ftl Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the comments such that these aren't errors anymore? All of them in this file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks :)

Comment thread syntax/grammar.mjs
@stasm stasm merged commit 741be04 into projectfluent:master Nov 9, 2018
@stasm stasm deleted the any-unicode-char branch November 9, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants