Fix typos & wording in README + fix of book compilation errors#208
Conversation
burlakvo
left a comment
burlakvo
left a comment
There was a problem hiding this comment.
@dev99problems, thanks for contributing!
There is one small notice regarding contributors.txt and in other files, I could suggest rewording "проект" into "проєкт"
I haven't the ability to approve PRs, only commenting =)
|
|
||
| [source,tabsize=8] | ||
| ---- | ||
| include::contributors.txt[] |
There was a problem hiding this comment.
It's generated on the go by Rakefile, so there is no need for such changes
There was a problem hiding this comment.
Thanks for mentioning this!
I couldn't make bundle install land all the deps normally on ruby@3.2.2, for some reason there's a problem with
kindlegen@3.1.1 gem on my MacOS setup, so I wasn't able to run bundle exec rake normally.
Reverting this one
Was thinking about |
|
@hedrok якщо буде змога, могли б подивитись ці зміни? |
3 participants
Description
This brings some typos adjustments and wording updates to
README.mdto make wording there a bit more formaland a bit less authorish.
Also fixes 2 books generation errors:
contributors.txtfile — original eng. book now is providing a link to it incontributors.asc, instead or including it, but the fun part — I couldn't find thecontributors.txtfile itself in eng. repo either, so just switching fromincludingtolinkworked pretty wellasciidocformatting issue inbook/06-github/3-maintaining.ascsection