{{ message }}
Debugger continues to work despite Sketch name and folder name are not equal - #1197
Closed
awood0727 wants to merge 1 commit into
Closed
Debugger continues to work despite Sketch name and folder name are not equal#1197awood0727 wants to merge 1 commit into
awood0727 wants to merge 1 commit into
Conversation
Signed-off-by: Amante' Woodley <awood0727@gmail.com> Co-authored-by: Nia Perez <nia.perez.506@gmail.com> Co-authored-by: Kayla Bobo <kay3583@gmail.com> Co-authored-by: Silas Morgan <victorsmorgan@gmail.com>
Member
Stefterv
approved these changes
Aug 27, 2025
Contributor
Author
|
Hello @Stefterv, our thought process with the Debugger.pdeToSketchLine code was due to us creating a similar return line for the .pde files like was given for the .java files in LineBreakpoint.java we assumed that we needed to also create a similar function in Debugger. However if you believe that functions is not needed than we can take the code out if you would like us too. |
Member
|
Yeah if the function is unused, which it seems to be, please remove it. Great work! |
Contributor
Author
|
Apologies for the delay but the fix should be implemented by the end of the week, my classes started a couple weeks ago so I'm trying to find a good time. |
3 tasks
Contributor
Author
Member
|
Hey @awood0727 great thank you! Can you please close this PR then? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
This PR resolves #1190
Changes
Tests
Screenshots
Before Implementation
After Implementation