{{ message }}
incorrect uniform resolution - #1082
Open
AhmedMagedC wants to merge 1 commit into
Open
Conversation
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1063
Changes
correctly set the uniform resolution to reflect the changes in pixelDensity
Why?
when pixelDensity is set to 2 either implicitly (starting from Processing 4.4.3 version) ,or when called when creating a sketch
the physical resolution (width and height) is doubled, but that isn't reflected on the
uniform resolution(the rendering resolution)so for example in
conway.glslthis piece of codevec2 position = ( gl_FragCoord.xy / resolution.xy );results in inconsistent position (wrong scaling) becauseuniform resolutionstill uses the logical resolution specificed insize()functionTests
i tested all shaders examples, and everything seems fine except for two examples
deform, mouseX and mouseY also isn't reflected the change of pixelDensity
a simple solution is to multiple mouseX and mouseY by pixelDensity to reflect the correct position
DemoProjection this one is missed up, but i think it's related to the code written in sketch not sure about that