Added fancy pde:// install button by SableRaf · Pull Request #27 · processing/processing-android-website · GitHub
Skip to content

Added fancy pde:// install button - #27

Closed
SableRaf wants to merge 13 commits into
mainfrom
install-button
Closed

Added fancy pde:// install button#27
SableRaf wants to merge 13 commits into
mainfrom
install-button

Conversation

@SableRaf

Copy link
Copy Markdown
Contributor

Added an install button point at the .pdex file using the custom pde:// uri protocol.

The button includes a tooltip with fallback instructions.

image

Context

Processing 4.2 added the new pde:// protocol which allows you to open Processing sketches and contributions in the PDE directly from the browser. It builds up on the previous addition of bundled sketches and contributions with the .pdez and .pdex formats.

@netlify

netlify Bot commented Jul 16, 2024

Copy link
Copy Markdown

@SableRaf

SableRaf commented Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

Hmmm... Looks like the changes I made are causing Processing to see the source as untrusted. This didn't happen with a simple link as it is currently set up on the production deploy. Nevermind it's also broken today. Pretty sure it worked when I tried it yesterday.

cc @mingness @Stefterv

image

@Stefterv

Copy link
Copy Markdown
Member

@SableRaf

SableRaf commented Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

Oh my bad! You're right. This is a necessary warning. I just got confused by the scheme8019... title which really obfuscates the question mark. I wonder where that string comes from 🤔 It should be the name of the contribution.

Edit: Getting closer...

String baseName = contribFile.getName();
baseName = baseName.substring(0, baseName.length() - CONTRIB_BUNDLE_EXT.length());

Comment thread es/gallery/index.html

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these side-wide changes be part of a different PR? It hides what you actually did

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it! I'm splitting this PR into several more specific ones.

@SableRaf

Copy link
Copy Markdown
Contributor Author

@SableRaf SableRaf closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants