{{ message }}
Upgrade Go version from 1.24 to 1.26#4737
Merged
Merged
Conversation
Code coverage summaryNote:
adapterstestRefer here for heat map coverage report |
Contributor
|
Curious, entire json and yaml files are showing up as a change. Did you inadvertently change the line endings? |
SyntaxNode
reviewed
Apr 1, 2026
Contributor
|
The go version should be at least 1.26.2. Previous versions 1.26.x have bugs in delve debugger |
bsardo
reviewed
May 13, 2026
bsardo
left a comment
bsardo
left a comment
Collaborator
There was a problem hiding this comment.
I understand Go 1.26 has a stricter linter which is driving some of these changes and we will accept those changes as part of this PR. However, typically those changes should be in a separate PR that would be merged prior to the Go version upgrade so please follow that guidance going forward.
Collaborator
|
Also note that this PR will be its own release. |
Contributor
Good catch — yes, the editor saved those four files with CRLF line endings, which made the entire file render as changed even though only a few lines actually differ. Fixed it |
Collaborator
|
@anishb-ms now that we merged in my change to the adapter code coverage workflow, can you merge with master to verify that that workflow failure goes away here? |
Code coverage summaryNote:
adapterstestRefer here for heat map coverage report |
Contributor
All validations are passing successfully now. |
SyntaxNode
approved these changes
May 18, 2026
linux019
approved these changes
May 20, 2026
bsardo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading Go version build from 1.24 and 1.26.
Doing version compatibility fixes
Testing
Ran all Unit tests
Tested following endpoints -