GVL: Periodically fetch latest valid IDs indicating deletions by bsardo · Pull Request #4700 · prebid/prebid-server · GitHub
Skip to content

GVL: Periodically fetch latest valid IDs indicating deletions#4700

Merged
bsardo merged 7 commits into
prebid:masterfrom
bsardo:issue-4439-handle-deleted-gvl-entries
Mar 4, 2026
Merged

GVL: Periodically fetch latest valid IDs indicating deletions#4700
bsardo merged 7 commits into
prebid:masterfrom
bsardo:issue-4439-handle-deleted-gvl-entries

Conversation

@bsardo

@bsardo bsardo commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Implements #4439

@bsardo bsardo self-assigned this Feb 24, 2026
@bsardo bsardo added the PBS 4.0 label Feb 24, 2026
@bsardo bsardo assigned karwaankit32 and SyntaxNode and unassigned bsardo Feb 24, 2026
@bsardo bsardo changed the title GVL: Periodically fetch latest valid IDs marking deletions GVL: Periodically fetch latest valid IDs indicating deletions Feb 24, 2026
Comment thread config/config.go Outdated
Comment thread gdpr/gvl_vendor_ids.go
Comment thread gdpr/gvl_vendor_ids.go
Comment thread gdpr/gvl_vendor_ids.go Outdated
Comment thread config/config.go Outdated
Comment thread gdpr/gvl_vendor_ids.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status code check happens after reading the body (line 90). The status check should come first, before [o.ReadAll]

Comment thread router/router.go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we think about shutting down the task? I noticed there's a start function, but I don't see anything for closing it.

@bsardo bsardo marked this pull request as ready for review March 2, 2026 23:21
@bsardo bsardo assigned anishb-ms and unassigned karwaankit32 Mar 3, 2026
anishb-ms
anishb-ms previously approved these changes Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants