Capitalize acronym names by pradyunsg · Pull Request #413 · pre-commit/pre-commit-hooks · GitHub
Skip to content

Capitalize acronym names - #413

Closed
pradyunsg wants to merge 1 commit into
pre-commit:masterfrom
pradyunsg:patch-1
Closed

Capitalize acronym names#413
pradyunsg wants to merge 1 commit into
pre-commit:masterfrom
pradyunsg:patch-1

Conversation

@pradyunsg

Copy link
Copy Markdown

I feel a little bad inside every time I look at these names. I finally decided to do something about it.

@asottile

Copy link
Copy Markdown
Member

@pradyunsg

Copy link
Copy Markdown
Author

I strongly prefer all-caps, since they are acronyms and should be capitalized in human-readable strings.

I think we should use all-caps for consistency with any other textual uses, instead of for-the-computer uses -- The JSON spec uses "JSON" and the TOML spec uses "TOML", in their sentences. I'm pretty sure XML, YAML and others would also be doing the same.


I understand the consistency suggestion you make and that's definitely better than status quo. I'm happy to make that change, if you insist on not doing all caps, and I'll update the PR. Just let me know if my paragraph above persuaded you. :)

@asottile

Copy link
Copy Markdown
Member

I'm willing to admit I'm wrong, but I'd still like them un-capitalized

while you're at it, I've been meaning to change the name for name-tests-test to enforce test file naming (to make it less confusing when the --django flag is passed) -- if you could make that fix as well as part of this that would be great :)

@pradyunsg

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants