{{ message }}
Repository navigation
don't leak GIT_* env into npm install for language: node - #3774
Merged
Merged
Conversation
When a node hook environment is installed from `git commit` inside a submodule, git exports absolute GIT_DIR / GIT_INDEX_FILE paths. `npm install git+file://<store clone>` inherited them, so npm's checkout of the hook repository overwrote the submodule's index and the commit failed with `fatal: unable to read <sha>`. Run the install with no_git_env(), as is already done for the initial clone in store.py. Signed-off-by: Chris Birkhold <cbirkhold@gmail.com>
asottile
force-pushed
the
node-no-git-env-npm-install
branch
from
October 12, 2026 20:26
8fd690a to
860d07d
Compare
rlichtenwalter
pushed a commit
to rlichtenwalter/kdtree
that referenced
this pull request
Oct 16, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update | |---|---|---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` |  |  | | minor | | [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` |  |  | repository | patch | | [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` |  |  | repository | patch | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit (pre-commit)</summary> ### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12) [Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0) \================== ##### Fixes - Fix `language: node` hooks during commit with `-a` or inside a submodule. - Regressed in 4.6.1. - [#​3773](pre-commit/pre-commit#3773) issue by [@​cbirkhold](https://github.com/cbirkhold). - [#​3774](pre-commit/pre-commit#3774) PR by [@​cbirkhold](https://github.com/cbirkhold). ### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10) [Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2) \================== ##### Fixes - Fix `language: node` hooks that contain `"scripts": {"build": ...}` with npm 11.x. - Regressed in 4.6.1. - [#​3737](pre-commit/pre-commit#3737) issue by [@​mheiges](https://github.com/mheiges). - [#​3743](pre-commit/pre-commit#3743) PR by [@​asottile](https://github.com/asottile). ### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21) [Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1) \================== ##### Fixes - Install `language: node` hooks via `git`. - Fixes npm 12.x compatibility - [#​3719](pre-commit/pre-commit#3719) PR by [@​asottile](https://github.com/asottile). - [#​3517](pre-commit/pre-commit#3517) issue by [@​ojob](https://github.com/ojob). - Set `JULIA_DEPOT_PATH` for `language: julia`. - [#​3711](pre-commit/pre-commit#3711) PR by [@​damonbayer](https://github.com/damonbayer). - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@​damonbayer](https://github.com/damonbayer). - Produce error on mistyped `--repo` for `pre-commit autoupdate`. - [#​3701](pre-commit/pre-commit#3701) PR by [@​mxr](https://github.com/mxr). - [#​3695](pre-commit/pre-commit#3695) issue by [@​mxr](https://github.com/mxr). - Improve performance of commit existence check in `pre-push`. - [#​3726](pre-commit/pre-commit#3726) PR by [@​asottile](https://github.com/asottile). - [#​3604](pre-commit/pre-commit#3604) issue by [@​ptarjan](https://github.com/ptarjan). - Avoid duplicating conflicted filenames during `pre-commit run --all-files`. - [#​3727](pre-commit/pre-commit#3727) PR by [@​asottile](https://github.com/asottile). - [#​3706](pre-commit/pre-commit#3706) issue by [@​RomanValov](https://github.com/RomanValov). ### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21) [Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0) \================== ##### Features - `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier usage with `git` 2.54+ git hooks. - [#​3662](pre-commit/pre-commit#3662) PR by [@​asottile](https://github.com/asottile). ##### Fixes - `pre-commit hook-impl`: `--hook-type` is required. - [#​3661](pre-commit/pre-commit#3661) PR by [@​asottile](https://github.com/asottile). </details> <details> <summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary> ### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) [Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) ### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) [Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) </details> <details> <summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary> ### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10) [Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://git.lichtenwalter.site/rlichten/kdtree/pulls/69 Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN Co-authored-by: Dependency Updater <svc-deps-bot@lichtenwalter.site>
rlichtenwalter
pushed a commit
to rlichtenwalter/mRMR
that referenced
this pull request
Oct 16, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update | |---|---|---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` |  |  | | minor | | [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` |  |  | repository | patch | | [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` |  |  | repository | patch | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit (pre-commit)</summary> ### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12) [Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0) \================== ##### Fixes - Fix `language: node` hooks during commit with `-a` or inside a submodule. - Regressed in 4.6.1. - [#​3773](pre-commit/pre-commit#3773) issue by [@​cbirkhold](https://github.com/cbirkhold). - [#​3774](pre-commit/pre-commit#3774) PR by [@​cbirkhold](https://github.com/cbirkhold). ### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10) [Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2) \================== ##### Fixes - Fix `language: node` hooks that contain `"scripts": {"build": ...}` with npm 11.x. - Regressed in 4.6.1. - [#​3737](pre-commit/pre-commit#3737) issue by [@​mheiges](https://github.com/mheiges). - [#​3743](pre-commit/pre-commit#3743) PR by [@​asottile](https://github.com/asottile). ### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21) [Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1) \================== ##### Fixes - Install `language: node` hooks via `git`. - Fixes npm 12.x compatibility - [#​3719](pre-commit/pre-commit#3719) PR by [@​asottile](https://github.com/asottile). - [#​3517](pre-commit/pre-commit#3517) issue by [@​ojob](https://github.com/ojob). - Set `JULIA_DEPOT_PATH` for `language: julia`. - [#​3711](pre-commit/pre-commit#3711) PR by [@​damonbayer](https://github.com/damonbayer). - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@​damonbayer](https://github.com/damonbayer). - Produce error on mistyped `--repo` for `pre-commit autoupdate`. - [#​3701](pre-commit/pre-commit#3701) PR by [@​mxr](https://github.com/mxr). - [#​3695](pre-commit/pre-commit#3695) issue by [@​mxr](https://github.com/mxr). - Improve performance of commit existence check in `pre-push`. - [#​3726](pre-commit/pre-commit#3726) PR by [@​asottile](https://github.com/asottile). - [#​3604](pre-commit/pre-commit#3604) issue by [@​ptarjan](https://github.com/ptarjan). - Avoid duplicating conflicted filenames during `pre-commit run --all-files`. - [#​3727](pre-commit/pre-commit#3727) PR by [@​asottile](https://github.com/asottile). - [#​3706](pre-commit/pre-commit#3706) issue by [@​RomanValov](https://github.com/RomanValov). ### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21) [Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0) \================== ##### Features - `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier usage with `git` 2.54+ git hooks. - [#​3662](pre-commit/pre-commit#3662) PR by [@​asottile](https://github.com/asottile). ##### Fixes - `pre-commit hook-impl`: `--hook-type` is required. - [#​3661](pre-commit/pre-commit#3661) PR by [@​asottile](https://github.com/asottile). </details> <details> <summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary> ### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) [Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) ### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) [Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) </details> <details> <summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary> ### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10) [Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://git.lichtenwalter.site/rlichten/mRMR/pulls/79 Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN Co-authored-by: Dependency Updater <svc-deps-bot@lichtenwalter.site>
rlichtenwalter
pushed a commit
to rlichtenwalter/popc
that referenced
this pull request
Oct 16, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update | |---|---|---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` |  |  | | minor | | [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` |  |  | repository | patch | | [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` |  |  | repository | patch | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit (pre-commit)</summary> ### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12) [Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0) \================== ##### Fixes - Fix `language: node` hooks during commit with `-a` or inside a submodule. - Regressed in 4.6.1. - [#​3773](pre-commit/pre-commit#3773) issue by [@​cbirkhold](https://github.com/cbirkhold). - [#​3774](pre-commit/pre-commit#3774) PR by [@​cbirkhold](https://github.com/cbirkhold). ### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10) [Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2) \================== ##### Fixes - Fix `language: node` hooks that contain `"scripts": {"build": ...}` with npm 11.x. - Regressed in 4.6.1. - [#​3737](pre-commit/pre-commit#3737) issue by [@​mheiges](https://github.com/mheiges). - [#​3743](pre-commit/pre-commit#3743) PR by [@​asottile](https://github.com/asottile). ### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21) [Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1) \================== ##### Fixes - Install `language: node` hooks via `git`. - Fixes npm 12.x compatibility - [#​3719](pre-commit/pre-commit#3719) PR by [@​asottile](https://github.com/asottile). - [#​3517](pre-commit/pre-commit#3517) issue by [@​ojob](https://github.com/ojob). - Set `JULIA_DEPOT_PATH` for `language: julia`. - [#​3711](pre-commit/pre-commit#3711) PR by [@​damonbayer](https://github.com/damonbayer). - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@​damonbayer](https://github.com/damonbayer). - Produce error on mistyped `--repo` for `pre-commit autoupdate`. - [#​3701](pre-commit/pre-commit#3701) PR by [@​mxr](https://github.com/mxr). - [#​3695](pre-commit/pre-commit#3695) issue by [@​mxr](https://github.com/mxr). - Improve performance of commit existence check in `pre-push`. - [#​3726](pre-commit/pre-commit#3726) PR by [@​asottile](https://github.com/asottile). - [#​3604](pre-commit/pre-commit#3604) issue by [@​ptarjan](https://github.com/ptarjan). - Avoid duplicating conflicted filenames during `pre-commit run --all-files`. - [#​3727](pre-commit/pre-commit#3727) PR by [@​asottile](https://github.com/asottile). - [#​3706](pre-commit/pre-commit#3706) issue by [@​RomanValov](https://github.com/RomanValov). ### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21) [Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0) \================== ##### Features - `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier usage with `git` 2.54+ git hooks. - [#​3662](pre-commit/pre-commit#3662) PR by [@​asottile](https://github.com/asottile). ##### Fixes - `pre-commit hook-impl`: `--hook-type` is required. - [#​3661](pre-commit/pre-commit#3661) PR by [@​asottile](https://github.com/asottile). </details> <details> <summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary> ### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) [Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) ### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) [Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) </details> <details> <summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary> ### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10) [Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://git.lichtenwalter.site/rlichten/popc/pulls/33 Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN Co-authored-by: Dependency Updater <svc-deps-bot@lichtenwalter.site>
rlichtenwalter
pushed a commit
to rlichtenwalter/vcp
that referenced
this pull request
Oct 16, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update | |---|---|---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` |  |  | | minor | | [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` |  |  | repository | patch | | [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` |  |  | repository | patch | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit (pre-commit)</summary> ### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12) [Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0) \================== ##### Fixes - Fix `language: node` hooks during commit with `-a` or inside a submodule. - Regressed in 4.6.1. - [#​3773](pre-commit/pre-commit#3773) issue by [@​cbirkhold](https://github.com/cbirkhold). - [#​3774](pre-commit/pre-commit#3774) PR by [@​cbirkhold](https://github.com/cbirkhold). ### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10) [Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2) \================== ##### Fixes - Fix `language: node` hooks that contain `"scripts": {"build": ...}` with npm 11.x. - Regressed in 4.6.1. - [#​3737](pre-commit/pre-commit#3737) issue by [@​mheiges](https://github.com/mheiges). - [#​3743](pre-commit/pre-commit#3743) PR by [@​asottile](https://github.com/asottile). ### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21) [Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1) \================== ##### Fixes - Install `language: node` hooks via `git`. - Fixes npm 12.x compatibility - [#​3719](pre-commit/pre-commit#3719) PR by [@​asottile](https://github.com/asottile). - [#​3517](pre-commit/pre-commit#3517) issue by [@​ojob](https://github.com/ojob). - Set `JULIA_DEPOT_PATH` for `language: julia`. - [#​3711](pre-commit/pre-commit#3711) PR by [@​damonbayer](https://github.com/damonbayer). - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@​damonbayer](https://github.com/damonbayer). - Produce error on mistyped `--repo` for `pre-commit autoupdate`. - [#​3701](pre-commit/pre-commit#3701) PR by [@​mxr](https://github.com/mxr). - [#​3695](pre-commit/pre-commit#3695) issue by [@​mxr](https://github.com/mxr). - Improve performance of commit existence check in `pre-push`. - [#​3726](pre-commit/pre-commit#3726) PR by [@​asottile](https://github.com/asottile). - [#​3604](pre-commit/pre-commit#3604) issue by [@​ptarjan](https://github.com/ptarjan). - Avoid duplicating conflicted filenames during `pre-commit run --all-files`. - [#​3727](pre-commit/pre-commit#3727) PR by [@​asottile](https://github.com/asottile). - [#​3706](pre-commit/pre-commit#3706) issue by [@​RomanValov](https://github.com/RomanValov). ### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21) [Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0) \================== ##### Features - `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier usage with `git` 2.54+ git hooks. - [#​3662](pre-commit/pre-commit#3662) PR by [@​asottile](https://github.com/asottile). ##### Fixes - `pre-commit hook-impl`: `--hook-type` is required. - [#​3661](pre-commit/pre-commit#3661) PR by [@​asottile](https://github.com/asottile). </details> <details> <summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary> ### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) [Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3) ### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) [Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2) </details> <details> <summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary> ### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10) [Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://git.lichtenwalter.site/rlichten/vcp/pulls/51 Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN Co-authored-by: Dependency Updater <svc-deps-bot@lichtenwalter.site>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


resolves #3773
Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs
npm install git+file://<store clone>, which clones and checks out with git. when the install happens fromgit commitinside a submodule, git has exported absoluteGIT_DIR/GIT_INDEX_FILE, so the checkout overwrote the submodule's index.With this change applied, the install runs with
no_git_env(), as the initial clone instore.pyalready does. only thenpm installcall changes. The environment hooks run in is unchanged.The new test fails without the change (the user repository's index ends up with
bin/main.jsandpackage.json) and passes with it. #3773 reproduces the issue in a Docker container. The same Dockerfile may be used to demonstrate the fix with:docker build --build-arg PRE_COMMIT=git+https://github.com/cbirkhold/ext-pre-commit@node-no-git-env-npm-install -t pre-commit-submodule-repro:fix . docker run --rm pre-commit-submodule-repro:fix