1. Release notes

Fixed an issue during logout or tenant switching where the device push token was previously deleted or expired on the server. The logout flow and workspace switching now complete cleanly without background errors.

2. Description (problem)

When logging out (Logout) or switching tenant (Switch Tenant, /tenants/ page), the client sends a DELETE /notifications/device/<token> request to detach the browser push token from the current user.

If the token was already automatically deleted on the backend (for example, when Google Firebase returned UnregisteredError or InvalidArgumentError during push delivery, prompting the server to delete the device record without notifying the client), or if a token from another user session remained in localStorage, the backend returns standard DRF 404 Not Found ({"detail":"Not found."}).

Previously, the global Axios interceptor (commonRequest) unconditionally logged any non-2xx response as an error (logger.error), triggering false positive issues in Sentry.

Where it occurred: on the /tenants/ page when switching organizations, and during user logout (Logout).

3. Context

• Task ID: 50949
• Sentry Issue: PNEUMATIC-FRONTEND-PROD-24V
• Sentry Project: pneumatic-frontend-prod
• Event count: 2 | Impacted users: 2
• Timeframe: First Seen: 2026-10-15 14:08:15 UTC → Last Seen: 2026-10-15 14:08:51 UTC
• Environment: prod
• URL: https://my.pneumatic.app/tenants/
• Code locations: frontend/src/public/api/commonRequest.ts, frontend/src/public/api/resetFirebaseDeviceToken.ts, frontend/src/public/firebase/utils.ts, frontend/src/public/redux/auth/saga.ts.

4. Solution

• Added support for declaring expected error HTTP status codes (expectedErrorStatuses) in commonRequest.
• When an API response returns an HTTP status included in expectedErrorStatuses, the interceptor logs it as an informational message (logger.info), preventing false error events in Sentry. The HTTP status is not masked as 200 OK — transport contract integrity is preserved.
• Declared status 404 as expected for device token reset (expectedErrorStatuses: [404]) in resetFirebaseDeviceToken.
• Made resetFirebaseDeviceToken in firebase/utils.ts asynchronous: the local token is now guaranteed to be removed from localStorage (localStorage.removeItem(FIREBASE_DEVICE_STORAGE_KEY)) after the API call, and the logout saga now waits for it via yield call(resetFirebaseDeviceToken).

5. Implementation details

• Request error interceptor (commonRequest.ts):
  • Was: Any non-success error not matching isExpectedClientError(responseData) was logged with logger.error, generating a Sentry event.
  • Now: Added expectedErrorStatuses?: number[] to ICommonRequestOptions; the matching AxiosRequestConfig augmentation lives in typings/axios.d.ts (see item 7). When the response status matches an entry in the array, the error is logged as logger.info.
• Token reset API (resetFirebaseDeviceToken.ts):
  • Was: Request was called with { shouldThrow: false, responseType: 'empty' }.
  • Now: Added expectedErrorStatuses: [404].
• Local token cleanup (firebase/utils.ts):
  • Was: resetFirebaseDeviceTokenAPI was called synchronously without awaiting response, and localStorage was never cleared.
  • Now: Function is declared async: it awaits await resetFirebaseDeviceTokenAPI(token) and then executes localStorage.removeItem(FIREBASE_DEVICE_STORAGE_KEY).
• Logout saga (redux/auth/saga.ts):
  • Was: Direct synchronous call to resetFirebaseDeviceToken().
  • Now: Delegated to saga effect: yield call(resetFirebaseDeviceToken).

6. What to test

6.1 Preconditions

• To verify Sentry event suppression (item 6.4), the staging environment is required (Sentry is disabled in local).
• A test account with ability to log out and switch organizations (/tenants/).
• Browsers: Chrome Desktop, Safari Desktop, Chrome Mobile, Safari Mobile.

6.2 Positive scenarios

6.3 Negative scenarios and edge cases

6.4 Verification points

• Sentry (staging): on receiving 404 from /notifications/device/<token>, no new Response Error: 404 {"detail":"Not found."} events are created.
• Browser console: 404 response on device token reset is printed at info level, not error.
• Network (DevTools): DELETE /notifications/device/<token> request is made and retains its 404 status (backend HTTP contract is not masked).
• Application → Local Storage: firebase_device_token key is removed from localStorage under both outcomes (204 success or 404 not found).

6.5 API checks

• Outgoing request:
  • Method: DELETE
  • URL: /api/v2/notifications/device/<token>/ (where <token> is the value from localStorage.firebase_device_token).
  • Request body: empty.
• Incoming response:
  • When token exists: HTTP 204 No Content.
  • When token is missing or expired: HTTP 404 Not Found, body {"detail":"Not found."}.
  • Client behavior: in both cases the logout or tenant switch flow continues uninterrupted.

6.6 What was NOT tested

• Real push notification delivery via Google Firebase Cloud Messaging (only device token deregistration was tested).
• Manual testing in all 4 browser environments (tables in 6.2, 6.3, 7, and 8 are provided as a blank QA checklist).
• Load testing.
• Production environment verification (verified via unit test suite and local builds).

7. Refactoring

The refactoring keeps type declarations in one place of the project (src/typings) instead of scattering them across application code.

Axios type declaration for expectedErrorStatuses.

• Description: The AxiosRequestConfig augmentation with the expectedErrorStatuses field was declared directly in commonRequest.ts (declare module 'axios'). It was moved to a separate file, frontend/src/typings/axios.d.ts, next to the other type declaration files of the project. commonRequest.ts now has an import type {} from '../../typings/axios', which makes the augmentation visible to ts-node (it ignores include from tsconfig, as noted in the code comment). Application behavior does not change — only the type declaration was moved.
• What to check:

8. Testing of affected places

Changes touched the global commonRequest.ts interceptor used by all API requests in the application, and the logout saga in redux/auth/saga.ts.

9. Unit tests

The following scenarios are covered:

1. interceptorError.test.ts:
   • Request with expectedErrorStatuses: [404] upon receiving 404 invokes logger.info without calling logger.error.
   • Request without expectedErrorStatuses upon receiving 404 continues calling logger.error.
2. resetFirebaseDeviceToken.test.ts:
   • Invocation of resetFirebaseDeviceToken(token) sends HTTP method DELETE, correct URL /notifications/device/<token>, and options { shouldThrow: false, responseType: 'empty', expectedErrorStatuses: [404] }.
3. utils.test.ts:
   • Function resetFirebaseDeviceToken() reads token from localStorage, calls reset API, and removes token from localStorage.
   • When no token is in localStorage, no API request is sent.

All tests were validated using TDD (failed with Expected logger.info / Received logger.error on unpatched code, pass cleanly on patched code).

10. Commits

• 5c9699071 — 50949 fix(api): ignore 404 on device token reset
• 1c09b2fca — 50949 refactor(api): move axios type to typings

Closes https://pneumatic.sentry.io/issues/PNEUMATIC-FRONTEND-PROD-24V