Fixes/workaround for upcoming (> v3.4.3) ggplot2 release by cpsievert · Pull Request #2301 · plotly/plotly.R · GitHub
Skip to content

Fixes/workaround for upcoming (> v3.4.3) ggplot2 release#2301

Merged
cpsievert merged 12 commits intomasterfrom
dev-ggplot2-fixes
Oct 11, 2023
Merged

Fixes/workaround for upcoming (> v3.4.3) ggplot2 release#2301
cpsievert merged 12 commits intomasterfrom
dev-ggplot2-fixes

Conversation

@cpsievert
Copy link
Copy Markdown
Collaborator

@cpsievert cpsievert commented Oct 6, 2023

This is just a draft for now -- starting a PR to get visual testing results back

TODO

  • Double-check these fixes work well with CRAN version of ggplot2

Comment thread R/ggplotly.R Outdated
Comment thread R/ggplotly.R Outdated
@cpsievert
Copy link
Copy Markdown
Collaborator Author

@cpsievert cpsievert marked this pull request as ready for review October 10, 2023 21:26
@cpsievert cpsievert merged commit 22d715d into master Oct 11, 2023
@cpsievert cpsievert deleted the dev-ggplot2-fixes branch October 11, 2023 00:41
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpsievert, it seems to me you are hitting jeroen/jsonlite#420 here, that was fixed on jsonlite 1.8.7. Maybe you want to update your jsonlite locally 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants