{{ message }}
Fix axis facets#1788
Merged
cpsievert merged 4 commits intoplotly:masterfrom Jun 17, 2020
trekonom:fix-axis-facets
Merged
Conversation
…et panels with only one category.
cpsievert
reviewed
Jun 12, 2020
Collaborator
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Contributor
Author
|
Just commited your changes and added a news item. Regarding the visual tests:
I also tried running the visual tests via docker ...
|
Collaborator
|
Hmm, are you in windows powershell? https://stackoverflow.com/a/51379726/1583084 |
Contributor
Author
|
(: Thanks a lot. It was the Powershell issue. Now the docker works like a charm. BTW: I also figured out my issue with visual testing inside RStudio. After running the tests via |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes a bug in
verify_attrwhich closes #1720 and #1577 .Adding the fix the reprex from #1720 is rendered like so
and the reprex from #1577 like so: