{{ message }}
added retry logic to HTTP requests#1656
Merged
cpsievert merged 4 commits intoplotly:masterfrom May 19, 2020
jameslamb:feat/retries
Merged
added retry logic to HTTP requests#1656cpsievert merged 4 commits intoplotly:masterfrom jameslamb:feat/retries
cpsievert merged 4 commits intoplotly:masterfrom
jameslamb:feat/retries
Conversation
Collaborator
Contributor
Author
|
Thanks. I've reverted all of the whitespace changes and replaced the |
cpsievert
reviewed
Mar 4, 2020
cpsievert
reviewed
May 19, 2020
cpsievert
reviewed
May 19, 2020
Collaborator
|
Sorry for the delay in getting this merged @jameslamb, this is looking good, and I'd be happy to take it on. Just a couple minor nitpicks:
|
Contributor
Author
will do, thanks for the review! |
Contributor
Author
|
Ok I just made the requested changes in 1bf6a4a. I've also rebased to |
Collaborator
|
Awesome, thank you! One last request: could you add a NEWS.md item (under improvements)? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome project!
In this PR, I'd like to propose swapping out calls to
httr::GET(),httr::PATCH(), etc. withhttr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic almost always improves the user experience with HTTP clients.I apologize for the whitespace changes. I have my editor set to trim excess horizontal whitespace when I save files. If you'd like me to revert those please let me know.