Conversation
camdecoster
left a comment
There was a problem hiding this comment.
Looks good. I made a few comments, but nothing stopping merge.
There was a problem hiding this comment.
Do you have a convention for using import typing vs. from typing import ...? If so, could you switch to that convention across all these type annotations?
There was a problem hiding this comment.
No conventions, some types are better import from typing_extensions to ensure backward compatibility in which case I prefer the from typing import ... syntax to easily switch between those.
There was a problem hiding this comment.
Does dict assign the same type as Dict?
There was a problem hiding this comment.
Yes, we still support 3.8 but later versions of Python prefer using that with the list[int] syntax.

Recreation of #3476 with further fixes
Fix #3139