{{ message }}
Repository navigation
[3.0.x] Fix reverse router for OptionalInt/Long/Double query params - #14252
Merged
mkurz merged 1 commit intoSep 30, 2026
Merged
Conversation
Backport of playframework#12995: use boxed Integer/Long/Double QueryStringBindable unbind so reversed URLs include the parameter key. Fixes playframework#14244
Contributor
Member
|
@Mergifyio backport 2.9.x |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #14244
Purpose
Backport of #12995 to the
3.0.xbranch.QueryStringBindableforjava.util.OptionalInt,OptionalLong, andOptionalDoubleusedvalue.toScala.getOrElse(0).toStringinunbind, which dropped the query parameter name and produced invalid reversed URLs (e.g.?111instead of?key=111).The fix delegates
unbindto the existing boxedInteger/Long/Doublebinders when a value is present, matchingOptional[T]behavior.Background Context
This is a straight backport of the merged main-line fix; no API or behavioral changes beyond correcting reverse routing for these Java optional primitive types.
References
Optional[Int|Long|Double]type of query param #12995 — Fix reverse router forOptional[Int|Long|Double]type of query param (merged onmain)Test plan
sbt "project Play" "Test / testOnly play.api.mvc.BindersSpec"(55 examples, 0 failures)RouterSpecreverse-route assertions from Fix reverse router forOptional[Int|Long|Double]type of query param #12995 (routes-compiler sbt scripted test)