[2.8.x] Bump version of sharable workflows to `v2` by ihostage · Pull Request #11269 · playframework/playframework · GitHub
Skip to content

[2.8.x] Bump version of sharable workflows to v2#11269

Merged
mergify[bot] merged 2 commits into
playframework:2.8.xfrom
ihostage:bump-workflow-v2-2_8_x
May 6, 2022
Merged

[2.8.x] Bump version of sharable workflows to v2#11269
mergify[bot] merged 2 commits into
playframework:2.8.xfrom
ihostage:bump-workflow-v2-2_8_x

Conversation

@ihostage

@ihostage ihostage commented May 6, 2022

Copy link
Copy Markdown
Member

As continue of #11262

@ihostage ihostage requested a review from mkurz May 6, 2022 08:23

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that for it does not mislead anyone

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's remove it. Actually I was hoping we could just copy the file to the main branch 1:1 every time we change something. However we can not copy 1:1, because we can not add ref: 2.8.x here because that would not be correct of course for pull requests and pushes. There will alway be a small difference, like we alway need to remove on push and on pull_requestfor the cron job (besides the ref: 2.8.x), see #11271

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wrote my thoughts 😄 At first like you I wanted to have a 1:1 copy and to add comment like "DON'T WORK IN NON-DEFAULT BRANCH". But when I understood that in main branch we should remove on/pull_request section and add ref in every jobs then I decided remove it 😄

@mergify mergify Bot merged commit 1b56a8c into playframework:2.8.x May 6, 2022
@ihostage ihostage deleted the bump-workflow-v2-2_8_x branch May 6, 2022 11:07
@mkurz mkurz added this to the 2.8.16 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants