{{ message }}
Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hardens the release workflow against command/string injection from the workflow_dispatch
versioninput (GHSA-749g-253p-pqxv). We assessed that advisory as not a security vulnerability because triggering the workflow already requires write access and themainenvironment enforces required reviewers, but the underlying interpolations are worth fixing as defense in depth.versioninput against a semver pattern before any step runs.version,github.ref, andGITHUB_TOKENto run steps viaenvwith quoted expansion instead of unquoted inline interpolation.build/sync-version.js, serialize the version intolib/meta.jswithJSON.stringifyso a crafted value cannot break out of the generated string literal.Verified the semver check accepts valid versions (including
v-prefixed and prerelease) and rejects injection payloads, the meta.js generator safely quotes a malicious payload instead of executing it, andnode test/internals/version.test.jsstill passes.