[DNM] Revert prometheus 1180 by you06 · Pull Request #53359 · pingcap/tidb · GitHub
Skip to content

[DNM] Revert prometheus 1180#53359

Closed
you06 wants to merge 2 commits intopingcap:release-8.1from
you06:revert-prometheus-1180
Closed

[DNM] Revert prometheus 1180#53359
you06 wants to merge 2 commits intopingcap:release-8.1from
you06:revert-prometheus-1180

Conversation

@you06
Copy link
Copy Markdown
Contributor

@you06 you06 commented May 17, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 17, 2024

@ti-chi-bot ti-chi-bot Bot added do-not-merge/invalid-title do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 17, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 17, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@tiprow
Copy link
Copy Markdown

tiprow Bot commented May 17, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
@you06 you06 force-pushed the revert-prometheus-1180 branch from 470bf75 to 08b9350 Compare May 17, 2024 14:34
@ti-chi-bot ti-chi-bot Bot added the component/dumpling This is related to Dumpling of TiDB. label May 17, 2024
@you06 you06 force-pushed the revert-prometheus-1180 branch from 08b9350 to 28388f4 Compare May 17, 2024 14:35
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from you06, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2024
@you06 you06 force-pushed the revert-prometheus-1180 branch from 28388f4 to 393dca9 Compare May 18, 2024 05:51
Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

comment

Signed-off-by: you06 <you1474600@gmail.com>

only allocate ballast when task received

Signed-off-by: you06 <you1474600@gmail.com>

set 32kb ballast

Signed-off-by: you06 <you1474600@gmail.com>
@you06 you06 force-pushed the revert-prometheus-1180 branch from 393dca9 to ec8e8d5 Compare May 20, 2024 04:39
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 20, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 27, 2024

@ti-chi-bot ti-chi-bot closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dumpling This is related to Dumpling of TiDB. do-not-merge/cherry-pick-not-approved do-not-merge/invalid-title do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants