{{ message }}
system variables: document tidb_opt_index_join_build_v2 compat#22739
Open
qiancai wants to merge 1 commit intopingcap:masterfrom
Open
system variables: document tidb_opt_index_join_build_v2 compat#22739qiancai wants to merge 1 commit intopingcap:masterfrom
qiancai wants to merge 1 commit intopingcap:masterfrom
Conversation
qiancai
added
translation/from-docs-cn
ti-chi-bot
Bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a placeholder file named temp.md. The reviewer noted that this file should be removed as it does not contain the documentation for tidb_opt_index_join_build_v2 mentioned in the pull request description, and suggested placing the documentation in the correct system variable files instead.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
This file appears to be a placeholder and does not contain the documentation for tidb_opt_index_join_build_v2 as described in the pull request title and description. Remove this file and include the documentation in the appropriate files (system-variables.md and system-variable-reference.md).
References
- The documentation should be complete and accurate, covering all aspects described in the pull request summary. (link)
Synced from: pingcap/docs-cn#21434 Target PR: pingcap#22739 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
github-actions
Bot
force-pushed
the
docs-index-join-build-v2-compat-21434
branch
from
95eb41e to
691df73
Compare
ti-chi-bot
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Document the compatibility behavior of
tidb_opt_index_join_build_v2.system-variables.md.OFFreturns an error and cannot switch back to v1.mysql.global_variablesafter upgrade are still treated asON.system-variable-reference.md.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?