{{ message }}
Conversation
Signed-off-by: legoraft <git@legoraft.com>
Signed-off-by: legoraft <git@legoraft.com>
Signed-off-by: legoraft <git@legoraft.com>
Signed-off-by: legoraft <git@legoraft.com>
yubiuser
reviewed
Jul 13, 2025
yubiuser
left a comment
yubiuser
left a comment
Member
There was a problem hiding this comment.
The IPv6 instructions couldn't be updated, as I currently don't have an IPv6 address in my home router.
Even if you don't use IPv6 - are you able to update the screenshots and the instructions? No need to change your local configuration, but it would be nice if we can get rid of the warning about the outdated IPv6 guide...
| All client devices on your network should now automatically be configured with a single IPv4 and single IPv6 address for DNS resolution. If you don't see your client devices update quickly enough, you *can* toggle Wi-Fi off/on or disconnect the Ethernet cable for a couple of seconds and then reconnect it. | ||
|
|
||
| !!! note | ||
| The default pi-hole behavior (local requests), doesn't work if you have multiple VLANs. You should switch to another [interface](../ftldns/interfaces.md). |
Member
There was a problem hiding this comment.
Suggested change
| The default pi-hole behavior (local requests), doesn't work if you have multiple VLANs. You should switch to another [interface](../ftldns/interfaces.md). | |
| The default Pi-hole interface binding behavior ('Allow only local requests'), doesn't work if you have multiple VLANs. You should switch to another [interface](../ftldns/interfaces.md). |
I think it does not work with local request only as all request for VLANs go to the router first. Instead of writing
switch to another [interface]
It might be better to suggest directly "Respond only on interace XXX"
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
The Unifi DNS instructions weren't fully up to date anymore in the docs. I updated the IPv4 tutorial and added some notes on VLANs. The IPv6 instructions couldn't be updated, as I currently don't have an IPv6 address in my home router.
How does this PR accomplish the above?:
I added new images and instructions to the Ubiquiti USG section of the docs.
By submitting this pull request, I confirm the following:
git rebase)