Allow using ::class keyword to load a context. by niconoe- · Pull Request #571 · phpmyadmin/sql-parser · GitHub
Skip to content

Allow using ::class keyword to load a context.#571

Merged
williamdes merged 1 commit into
phpmyadmin:5.10.xfrom
niconoe-:fix/allow-loading-context-via-fqcn
Aug 26, 2024
Merged

Allow using ::class keyword to load a context.#571
williamdes merged 1 commit into
phpmyadmin:5.10.xfrom
niconoe-:fix/allow-loading-context-via-fqcn

Conversation

@niconoe-

@niconoe- niconoe- commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

I noticed that you cannot use the ::class keyword on contexts to load them.

I updated the Context loaded to manage it, and upgraded the unit tests in charge.

@kamil-tekiela

Copy link
Copy Markdown
Contributor

Comment thread src/Context.php
@niconoe-

niconoe- commented Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

@MauricioFauth MauricioFauth changed the base branch from 5.9.x to 5.10.x August 25, 2024 17:25
@williamdes williamdes self-assigned this Aug 26, 2024
@williamdes williamdes added this to the 5.10.0 milestone Aug 26, 2024
williamdes added a commit that referenced this pull request Aug 26, 2024
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 8649874 into phpmyadmin:5.10.x Aug 26, 2024
@niconoe- niconoe- deleted the fix/allow-loading-context-via-fqcn branch August 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants