Fix using ? as a parameter by MauricioFauth · Pull Request #515 · phpmyadmin/sql-parser · GitHub
Skip to content

Fix using ? as a parameter#515

Merged
MauricioFauth merged 1 commit into
phpmyadmin:5.9.xfrom
MauricioFauth:question-mark-param
Sep 26, 2023
Merged

Fix using ? as a parameter#515
MauricioFauth merged 1 commit into
phpmyadmin:5.9.xfrom
MauricioFauth:question-mark-param

Conversation

@MauricioFauth

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 26, 2023

Copy link
Copy Markdown

Comment thread tests/data/misc/parseParameter2.out Outdated
- Fixes phpmyadmin#202
- Fixes phpmyadmin#412
- Fixes phpmyadmin#492
- Closes phpmyadmin#499
- Related to phpmyadmin#172

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Comment thread tests/data/bugs/gh492.out

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !
Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?

@MauricioFauth

Copy link
Copy Markdown
Member Author

Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?

Is there an issue for that?

@MauricioFauth MauricioFauth merged commit 24d734a into phpmyadmin:5.9.x Sep 26, 2023
@MauricioFauth MauricioFauth deleted the question-mark-param branch September 26, 2023 23:56
@MauricioFauth MauricioFauth self-assigned this Sep 26, 2023
@MauricioFauth MauricioFauth added this to the 5.9.0 milestone Sep 26, 2023
@williamdes

Copy link
Copy Markdown
Member

MauricioFauth added a commit that referenced this pull request Jan 20, 2024
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants