Make constants const by kamil-tekiela · Pull Request #505 · phpmyadmin/sql-parser · GitHub
Skip to content

Make constants const#505

Merged
MauricioFauth merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Make-constants-const
Sep 17, 2023
Merged

Make constants const#505
MauricioFauth merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Make-constants-const

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

@kamil-tekiela kamil-tekiela marked this pull request as draft September 6, 2023 16:22
@kamil-tekiela kamil-tekiela force-pushed the Make-constants-const branch 2 times, most recently from a269969 to 79e2d3c Compare September 6, 2023 23:37
@kamil-tekiela kamil-tekiela marked this pull request as ready for review September 6, 2023 23:44

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consts are still overridable, right ? (by inheritance)

@kamil-tekiela

Copy link
Copy Markdown
Contributor Author

@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Sep 16, 2023
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@MauricioFauth MauricioFauth merged commit 6b20105 into phpmyadmin:master Sep 17, 2023
@MauricioFauth MauricioFauth self-assigned this Sep 17, 2023
@kamil-tekiela kamil-tekiela deleted the Make-constants-const branch September 17, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants