Drop $options param from Component::build by kamil-tekiela · Pull Request #482 · phpmyadmin/sql-parser · GitHub
Skip to content

Drop $options param from Component::build#482

Merged
MauricioFauth merged 1 commit into
phpmyadmin:masterfrom
kamil-tekiela:Drop-$options
Jun 17, 2023
Merged

Drop $options param from Component::build#482
MauricioFauth merged 1 commit into
phpmyadmin:masterfrom
kamil-tekiela:Drop-$options

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

Only DataType was using it. OptionsArray pretended to use it, but it didn't. This can be easily achieved with a public mutable property.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@codecov

codecov Bot commented Jun 10, 2023

Copy link
Copy Markdown

@williamdes williamdes added this to the 6.0.0 milestone Jun 13, 2023
@williamdes williamdes requested a review from MauricioFauth June 13, 2023 20:24
@MauricioFauth MauricioFauth merged commit da08ab2 into phpmyadmin:master Jun 17, 2023
@MauricioFauth MauricioFauth self-assigned this Jun 17, 2023
williamdes added a commit that referenced this pull request Jun 29, 2023
Signed-off-by: William Desportes <williamdes@wdes.fr>
@kamil-tekiela kamil-tekiela deleted the Drop-$options branch August 30, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants