Remove Misc class by kamil-tekiela · Pull Request #454 · phpmyadmin/sql-parser · GitHub
Skip to content

Remove Misc class#454

Merged
williamdes merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Misc-2
Jun 1, 2023
Merged

Remove Misc class#454
williamdes merged 2 commits into
phpmyadmin:masterfrom
kamil-tekiela:Misc-2

Conversation

@kamil-tekiela

Copy link
Copy Markdown
Contributor

Follow up from #451 but this time I move the class to SelectStatement where it belongs due to feature envy.

@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Comment thread src/Statements/SelectStatement.php

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea !

@williamdes williamdes added this to the 6.0.0 milestone Jun 1, 2023
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
williamdes added a commit that referenced this pull request Jun 1, 2023
Pull-request: #454

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 0d4d75e into phpmyadmin:master Jun 1, 2023
@williamdes williamdes self-assigned this Jun 1, 2023
@kamil-tekiela kamil-tekiela deleted the Misc-2 branch June 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants