iframe-proxy

faissaloux · 2025-01-15T14:32:25Z

Fixes #19384

While I was investigating this issue, I have found that all ops does not work with varbinary as it should.

In this PR I have fixed the equal op with varbinary field as it's the one reported now, other ops should be fixed on other PRs.

In case the value starts with `0x`

In case the value is a simple string

The PR will modify the 'GetCookieName' functtion by hard coding the prefix ' __Secure-' to each cookie name when 'isHttps()' is true, Apparently the prefix will be recognise d and enforced by most browsers (ignored by the older ones).Update Config.php The raison d'aitre for this PR is contained in my issue # 18608. This PR will replace the line 953, part of the GetCookieName function : return $cookieName . ( $this->isHttps ? '_https' : '' ); with the amended line: return ( $this->isHttps() ? '__Secure-' : '’ ) . $cookieName . ( $this->isHttps() ? '_https' : ‘’ ); Signed-off-by: martin762 <martin762green@btinternet.com> Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> Signed-off-by: faissaloux <fwahabali@gmail.com>

…o QA_5_2

Signed-off-by: faissaloux <fwahabali@gmail.com>

williamdes · 2025-01-15T14:35:40Z

                && $func_type !== 'BETWEEN'
                && $func_type !== 'NOT BETWEEN'
            ) {
+                $quot = $names === 'varbinary' ? '' : $quot;


Yeah you are right! I didn't see that line, I'll check it tonight.

kamil-tekiela · 2025-01-15T15:43:30Z

But that breaks the current behaviour. What if I really do want to search for a string like I can do with all other types?

faissaloux · 2025-01-15T18:17:06Z

But that breaks the current behaviour. What if I really do want to search for a string like I can do with all other types?

Do you mean you need to search for a sting on a varbinary field?

kamil-tekiela · 2025-01-15T18:36:03Z

But that breaks the current behaviour. What if I really do want to search for a string like I can do with all other types?

Do you mean you need to search for a sting on a varbinary field?

Yes, that should be possible by default.

faissaloux · 2025-01-15T20:38:01Z

But that breaks the current behaviour. What if I really do want to search for a string like I can do with all other types?

Do you mean you need to search for a sting on a varbinary field?

Yes, that should be possible by default.

Isn't this what = " operator is for?

= shouldn't add any quotes.
=" should add quotes.

Can you confirm this.

kamil-tekiela · 2025-01-15T20:51:46Z

Isn't this what = " operator is for?

No, that's not what this is for. This option allows you to search for an empty string. Try it, you can't enter the value because the condition will always be an empty string.

faissaloux · 2025-01-15T21:03:00Z

Isn't this what = " operator is for?

No, that's not what this is for. This option allows you to search for an empty string. Try it, you can't enter the value because the condition will always be an empty string.

Oh it's confusing, so this is another issue that I should fix later on. Noted!

Can you give me an example where you gonna need quotes on a binary field please.

kamil-tekiela · 2025-01-15T21:12:23Z

Can you give me an example where you gonna need quotes on a binary field please.

I am not sure what you're asking but basically any text would need quotes.

SELECT * FROM t WHERE vbin = 'foo';

The varbinary and binary types are basically text storage. And as with any text, it needs to be quoted. See https://dev.mysql.com/doc/refman/8.4/en/binary-varbinary.html

faissaloux · 2025-01-15T21:53:18Z

So I'll add the quotes only if the inserted value is a simple string like foo, if it's not (eg: 0xfoo) quotes should not be used.

kamil-tekiela · 2025-01-15T22:05:01Z

Yeah, that could work but how will you know when it's a special value?

faissaloux · 2025-01-15T22:08:53Z

Yeah, that could work but how will you know when it's a special value?

Yeah exactly that's what I'm thinking about, the only idea I have now is check if the string starts with 0x we don't add the quotes.

Signed-off-by: faissaloux <fwahabali@gmail.com>

williamdes · 2025-01-15T23:53:35Z

            if (
-                preg_match('@char|binary|blob|text|set|date|time|year|uuid@i', $types)
+                (
+                    preg_match('@char|binary|blob|text|set|date|time|year|uuid@i', $types)


this new version of the check is confusing me

Can you elaborate.

Yes, sorry
why was the varbinary type not added to the list ?
is there a case where varbinary is different from binary and not used in the 0x form ?

why was the varbinary type not added to the list ?

I didn't have to add it since there is binary (substring) that detects it.

is there a case where varbinary is different from binary and not used in the 0x form ?

As @kamil-tekiela said and I tested it yes, it can be stored as normal string.

I still don't know about this. What if I search for a string 0x? Then the search query will be broken and now you have another more serious bug. I'd rather either not change anything or create a separate option allowing the user to provide a self-quoted string/numerical value.

williamdes

Okay, thank you both for the review and work !

kamil-tekiela · 2025-01-17T01:29:58Z

martin762 and others added 5 commits June 19, 2024 18:53

Merge branch 'QA_5_2' of https://github.com/faissaloux/phpmyadmin int…

0c85483

…o QA_5_2

Merge branch 'QA_5_2' of https://github.com/faissaloux/phpmyadmin int…

782bba4

…o QA_5_2

Merge branch 'QA_5_2' of https://github.com/faissaloux/phpmyadmin int…

63f26e3

…o QA_5_2

fix varbinary equal search

f8cf6a7

Signed-off-by: faissaloux <fwahabali@gmail.com>

williamdes reviewed Jan 15, 2025

View reviewed changes

williamdes added the Awaiting Maintainer Response label Jan 15, 2025

williamdes mentioned this pull request Jan 15, 2025

Searching on a VARBINARY field #19384

Open

MauricioFauth added Awaiting Author Updates and removed Awaiting Maintainer Response labels Jan 15, 2025

add quotes to only simple string value, if starts with '0x' don't

4d25a41

Signed-off-by: faissaloux <fwahabali@gmail.com>

faissaloux requested a review from williamdes January 15, 2025 23:02

williamdes reviewed Jan 15, 2025

View reviewed changes

williamdes approved these changes Jan 17, 2025

View reviewed changes

williamdes removed the Awaiting Author Updates label Jan 17, 2025

williamdes added this to the 5.2.2 milestone Jan 17, 2025

williamdes removed this from the 5.2.2 milestone Jan 17, 2025

williamdes changed the title ~~Fix varbinary equal search~~ Fix #19384 - varbinary equal search Jan 17, 2025

williamdes marked this pull request as draft January 17, 2025 22:47

faissaloux mentioned this pull request Jan 18, 2025

Made Search operators = ''/ != '' more obvious #19542

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

faissaloux commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In case the value starts with 0x

In case the value is a simple string

Uh oh!

williamdes Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

faissaloux Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

kamil-tekiela commented Jan 15, 2025

Uh oh!

faissaloux commented Jan 15, 2025

Uh oh!

kamil-tekiela commented Jan 15, 2025

Uh oh!

faissaloux commented Jan 15, 2025

Uh oh!

kamil-tekiela commented Jan 15, 2025

Uh oh!

faissaloux commented Jan 15, 2025

Uh oh!

kamil-tekiela commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

faissaloux commented Jan 15, 2025

Uh oh!

kamil-tekiela commented Jan 15, 2025

Uh oh!

faissaloux commented Jan 15, 2025

Uh oh!

williamdes Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

faissaloux Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

williamdes Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

faissaloux Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

kamil-tekiela Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

williamdes left a comment

Choose a reason for hiding this comment

Uh oh!

kamil-tekiela commented Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

faissaloux commented Jan 15, 2025 •

edited

Loading

In case the value starts with `0x`

kamil-tekiela commented Jan 15, 2025 •

edited

Loading