Initial implementation by pfrenssen · Pull Request #1 · php-task-runner/scss · GitHub
Skip to content

Initial implementation#1

Merged
claudiu-cristea merged 5 commits into
masterfrom
initial-implementation
Jun 3, 2020
Merged

Initial implementation#1
claudiu-cristea merged 5 commits into
masterfrom
initial-implementation

Conversation

@pfrenssen

Copy link
Copy Markdown
Member

No description provided.

@claudiu-cristea claudiu-cristea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job. I have only two remarks regarding this repo:

  1. I see this entry in composer.json:
    "autoload": {
        "psr-4": {
            "TaskRunner\\Scss\\": "./src/"
        }
    },
    and I cannot figure out which file/class needs this mapping.
  2. I think this repo deserves a README.md, even it's a very brief one. We probably can show there the build badge (?)

@pfrenssen

Copy link
Copy Markdown
Member Author

@claudiu-cristea claudiu-cristea merged commit 7c9b72f into master Jun 3, 2020
@claudiu-cristea claudiu-cristea deleted the initial-implementation branch June 3, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants