{{ message }}
Be explicit about mixed context elements#70
Merged
Conversation
If we do not do that, SA tools like PHPStan ask that the type be documented more precisely in implementations.
greg0ire
added a commit
to greg0ire/migrations
that referenced
this pull request
Mar 22, 2020
Just replacing the whole phpdoc with what's written in the interface leads to phpcs no longer seeing that there is inheritance, and forcefully adding a string type declaration in the signature, which makes it incompatible with the interface. A PR has been opened to fix the interface: php-fig/log#70
greg0ire
added a commit
to greg0ire/migrations
that referenced
this pull request
Mar 22, 2020
Just replacing the whole phpdoc with what's written in the interface leads to phpcs no longer seeing that there is inheritance, and forcefully adding a string type declaration in the signature, which makes it incompatible with the interface. A PR has been opened to fix the interface: php-fig/log#70
greg0ire
added a commit
to greg0ire/migrations
that referenced
this pull request
Mar 22, 2020
Just replacing the whole phpdoc with what's written in the interface leads to phpcs no longer seeing that there is inheritance, and forcefully adding a string type declaration in the signature, which makes it incompatible with the interface. A PR has been opened to fix the interface: php-fig/log#70
greg0ire
added a commit
to greg0ire/migrations
that referenced
this pull request
Mar 22, 2020
Just replacing the whole phpdoc with what's written in the interface leads to phpcs no longer seeing that there is inheritance, and forcefully adding a string type declaration in the signature, which makes it incompatible with the interface. A PR has been opened to fix the interface: php-fig/log#70
greg0ire
added a commit
to doctrine/migrations
that referenced
this pull request
Mar 22, 2020
Just replacing the whole phpdoc with what's written in the interface leads to phpcs no longer seeing that there is inheritance, and forcefully adding a string type declaration in the signature, which makes it incompatible with the interface. A PR has been opened to fix the interface: php-fig/log#70
Jean85
approved these changes
Mar 23, 2020
Jean85
left a comment
Jean85
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 but we need the editor's approval here
Contributor
Author
Collaborator
|
Now |
Contributor
Author
greg0ire
added a commit
to greg0ire/migrations
that referenced
this pull request
Mar 24, 2020
This reverts commit c63446d. The issue has been fixed upstream in psr/log, and the fix released as 1.1.3 See php-fig/log#70
greg0ire
added a commit
to doctrine/migrations
that referenced
this pull request
Mar 24, 2020
This reverts commit c63446d. The issue has been fixed upstream in psr/log, and the fix released as 1.1.3 See php-fig/log#70
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do not do that, SA tools like PHPStan ask that the type be
documented more precisely in implementations.