{{ message }}
Repository navigation
Conversation
vincentchalamon
requested changes
Feb 22, 2023
Contributor
There was a problem hiding this comment.
I don't think injecting the url argument in parsers is a good design. Parsers are designed to be created with a single Reflection object from any place. Adding this url argument will impose to carry it from parser to parser.
ClassParser objects are created:
- in Twig extensions
- in parsers: TypeParser, ClassParser, MethodParser
- in Commands
As the url is dedicated for rendering the view, converting the parser object as a view object (handling this url argument) and injecting it to the view might be better, as you suggested.
Contributor
There was a problem hiding this comment.
What is this type for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.