{{ message }}
fix(worker): incorrect session state#2193
Closed
xavierleune wants to merge 1 commit into
Closed
Conversation
This was referenced Feb 16, 2026
Member
Contributor
Author
Contributor
|
Looks a bit cleaner than the previous solution, you'll also have to add BC for PHP 8.2 https://github.com/php/frankenphp/actions/runs/22057186532/job/63728080602?pr=2193 Would also probably be nice to add tests that somewhat reproduce #2190 and #2185, since with this solution we'd have to keep up with changes in the session extension. |
Contributor
Author
|
Thanks for the feedback. I'll try to have a small reproducer but was unable to so far. For the future I think we may propose a small change in php to expose a clean api to remove the need to follow upcoming changes. A small function with the subset reproduced here would do the trick. |
dunglas
approved these changes
Feb 18, 2026
dunglas
left a comment
dunglas
left a comment
Member
There was a problem hiding this comment.
Could you please rebase to see if tests are green @xavierleune?
It would be nice if you could check the "allow maintainers to push code" checkbox so we could do that directly, btw :)
Thanks for your contribs!!
Contributor
Author
dunglas
added a commit
that referenced
this pull request
Feb 23, 2026
Revert the INI snapshot/restore mechanism from #2139 which caused issues with frameworks that lazily set ini values like session.save_path (#2185). Replace the session handler snapshot/restore with a simpler direct session state reset from #2193, which preserves mod_user_names across requests without requiring session module reload. Co-Authored-By: Xavier Leune <xavier.leune@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dunglas
added a commit
that referenced
this pull request
Feb 23, 2026
Revert the INI snapshot/restore mechanism from #2139 which caused issues with frameworks that lazily set ini values like session.save_path (#2185). Replace the session handler snapshot/restore with a simpler direct session state reset from #2193, which preserves mod_user_names across requests without requiring session module reload. Co-Authored-By: Xavier Leune <xavier.leune@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dunglas
added a commit
that referenced
this pull request
Feb 23, 2026
Revert the INI snapshot/restore mechanism from #2139 which caused issues with frameworks that lazily set ini values like session.save_path (#2185). Replace the session handler snapshot/restore with a simpler direct session state reset from #2193, which preserves mod_user_names across requests without requiring session module reload. Co-Authored-By: Xavier Leune <xavier.leune@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dunglas
added a commit
that referenced
this pull request
Feb 23, 2026
Revert the INI snapshot/restore mechanism from #2139 which caused issues with frameworks that lazily set ini values like session.save_path (#2185). Replace the session handler snapshot/restore with a simpler direct session state reset from #2193, which preserves mod_user_names across requests without requiring session module reload. Co-Authored-By: Xavier Leune <xavier.leune@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
johanjanssens
pushed a commit
to johanjanssens/frankenphp
that referenced
this pull request
Feb 26, 2026
Revert the INI snapshot/restore mechanism from php#2139 which caused issues with frameworks that lazily set ini values like session.save_path (php#2185). Replace the session handler snapshot/restore with a simpler direct session state reset from php#2193, which preserves mod_user_names across requests without requiring session module reload. Co-Authored-By: Xavier Leune <xavier.leune@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext/session/php_session