{{ message }}
Repository navigation
Calculate content-md5 on S3 only when required. - #2592
Merged
Merged
Conversation
pgguru
reviewed
Apr 7, 2025
pgguru
left a comment
pgguru
left a comment
Contributor
There was a problem hiding this comment.
The name of this flag seems odd to me; perhaps something indicating an action like computeMd5, or more of an attribute about the param likerequiresMd5.
Member
Author
pgguru
approved these changes
Apr 9, 2025
pgguru
left a comment
pgguru
left a comment
Contributor
There was a problem hiding this comment.
Fine with the flag as-is, I'm content with the content as it were.</groan>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content-md5 header was generated for all requests with content but it is only required for batch delete requests. It is not clear why this header is required when x-amz-content-sha256 is also provided or why it is required only for this request but the documentation is clear on the matter. However, the content for these requests is relatively small compared to uploading files so omitting content-md5 where possible will save some CPU cycles.
Current AWS S3 and recent Minio don't complain if this header is missing but since it is still required by older versions of Minio and it is specified in the documentation for batch delete it is makes sense to keep it.