Add tests and CI integration by anaulin · Pull Request #6 · percy/percy-selenium-java · GitHub
Skip to content

Add tests and CI integration#6

Merged
anaulin merged 1 commit into
masterfrom
tests
Dec 12, 2018
Merged

Add tests and CI integration#6
anaulin merged 1 commit into
masterfrom
tests

Conversation

@anaulin

@anaulin anaulin commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

Could not figure out how to bypass CSP in Selenium without setting up a proxy. 😿

Successful CI run: https://circleci.com/gh/percy/percy-java-selenium/14
Corresponding Percy build: https://percy.io/sdks/percy-java-selenium/builds/1244849

@anaulin anaulin requested a review from djones December 11, 2018 19:06

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ok, I guess this is a thing! Thanks for making your way through this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is almost identical to what we have in the example app (just lightly simplified here). I could not find a convenient library to do programmatic simple static file serving over HTTP.

@djones djones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants