Change groupId from io.percy.selenium to io.percy by djones · Pull Request #2 · percy/percy-selenium-java · GitHub
Skip to content

Change groupId from io.percy.selenium to io.percy#2

Merged
djones merged 2 commits into
masterfrom
david-jones/group-id
Nov 19, 2018
Merged

Change groupId from io.percy.selenium to io.percy#2
djones merged 2 commits into
masterfrom
david-jones/group-id

Conversation

@djones

@djones djones commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@djones djones requested a review from anaulin November 15, 2018 18:56
Comment thread pom.xml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is totally the right thing to do. My mistake in setting it up this way.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave this package name as io.percy.selenium, because all the code in here is Selenium-specific, and not general Percy Java stuff.

My sense is that the groupId is sort of like the organization, and then each package within it is a different library (and the package tends to be aligned with the name of the artifactId. So I think we want a more granular package than io.percy for this library, unless we intend this to be the only Percy Java library, which would make this the io.percy Java library (and then we would change the artifactId to be percy-java, minus the selenium part).

This way, if we ever build more Java SDKs, we'd have:

groupId=io.percy
|
|- artifactId=percy-java-selenium ; package io.percy.selenium
|
|- artifactId=percy-java-appium ; package io.percy.appium
|
...

@anaulin anaulin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 :shipit:

@djones djones merged commit 56b9c57 into master Nov 19, 2018
@djones djones deleted the david-jones/group-id branch November 19, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants