{{ message }}
Repository navigation
feat: lock Konsole color scheme while keeping other app theming - #164
Open
mohammedaouamri5 wants to merge 3 commits into
Open
mohammedaouamri5 wants to merge 3 commits into
mohammedaouamri5 wants to merge 3 commits into
Conversation
kde-material-you-colors rewrites every Konsole profile's [Appearance] ColorScheme/Font to the generated MaterialYou values on wallpaper change. Snapshot the profiles before the wrapper runs and restore them right after, so Konsole keeps the user's own color scheme/font while the rest of the system is still themed. - new config appearance.wallpaperTheming.lockKonsoleColors (default true) - new 'Keep Konsole color scheme' checkbox under Settings > Interface > Color generation - other defaults untouched: Qt apps / Terminal theming stay enabled
Contributor
kde-material-you-colors rewrites the Konsole profiles and live-switches every running session over D-Bus, so the old snapshot/restore lock only kept new windows on the user's scheme while already-open windows still recolored. Disable its Konsole theming at the source instead (disable_konsole in its own config, synced from lockKonsoleColors), so profiles, generated color schemes and running sessions are all left untouched. Also skip the /dev/pts palette escape injection in applycolor.sh while the lock is on, and drop the now-unused backup/restore state plus the leftover mirror profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kde-material-you-colors rewrites every Konsole profile's [Appearance] ColorScheme/Font to the generated MaterialYou values on wallpaper change. Snapshot the profiles before the wrapper runs and restore them right after, so Konsole keeps the user's own color scheme/font while the rest of the system is still themed.