{{ message }}
fix(plugin-ecommerce): prevent crash when variant.options is undefined#16372
Open
Gap0507 wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(plugin-ecommerce): prevent crash when variant.options is undefined#16372Gap0507 wants to merge 1 commit intopayloadcms:mainfrom
Gap0507 wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…lidation crash Skip variants with non-array options to avoid TypeError when accessing length. Ensures backward compatibility with legacy or corrupted data.
Gap0507
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a runtime crash in the validateOptions hook of the ecommerce plugin when a variant has
optionsset toundefinedornull.Why?
The current implementation assumes that every variant has
optionsas an array. In real-world scenarios, this is not always true due to:When such a variant is encountered, the code attempts to access
.lengthon a non-array value, resulting in a TypeError and blocking all variant creation/updates for that product.How?
Added defensive checks using
Array.isArray():This approach:
Fixes #16368