{{ message }}
fix: Remove vitest since it's not compatible with webpack#266
Merged
Conversation
Member
Collaborator
Author
|
@evwilkin Fixed the branch it was going into, thanks for catching that. It should be going into the compass_theme branch. |
jpuzz0
reviewed
Feb 3, 2026
Collaborator
Author
There was a problem hiding this comment.
yes by jest in setup. It's used when running tests.
There was a problem hiding this comment.
If it were being used it would be specified as the testEnvironment in jest.config.cjs, right? If this is wrong, please explain.
Instead I see testEnvironment: 'jest-environment-jsdom',, so I'm still not sure how jest-fixed-jsdom is used, as its not imported or specified anywhere else I can see.
jpuzz0
approved these changes
Feb 3, 2026
jpuzz0
left a comment
jpuzz0
left a comment
There was a problem hiding this comment.
Outside of the 1 lint issue and 1 minor comment, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vitest can only be used with Vite. Since this product is being built using webpack at the moment, we can not use vitest. We can create a new vite branch to allow users who want to use vite to checkout that branch instead.
Closes issue: #264