{{ message }}
Added propagation control functions and fix implicit string conversion in headers.#367
Open
rayment wants to merge 7 commits intopaceholder:masterfrom
Open
Added propagation control functions and fix implicit string conversion in headers.#367rayment wants to merge 7 commits intopaceholder:masterfrom
rayment wants to merge 7 commits intopaceholder:masterfrom
Conversation
Added the ability to explicitly control propagation of data in DataFlowGraphModel through the use of a new virtual function canPropagate(ConnectionId), and another function propagate(NodeId) to request a propagation without having to update input/output data. These functions are both virtual so that deriviative dataflow models can specify their own control model. Signed-off-by: Finn Rayment <finn@rayment.fr>
The library will fail to compile if QT_NO_CAST_FROM_ASCII is set in any project that uses it due to implicit conversion of const char * to QString. Wrapping the constants moves string initialisation to compile-time and succeeds build. Signed-off-by: Finn Rayment <finn@rayment.fr>
Contributor
Author
Signed-off-by: Finn Rayment <finn@rayment.fr>
Signed-off-by: Finn Rayment <finn@rayment.fr>
Contributor
Author
Daguerreo
reviewed
Jun 14, 2023
Signed-off-by: Finn Rayment <finn@rayment.fr>
nolankramer
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I've added the ability to explicitly control propagation of data in
DataFlowGraphModelthrough the use of a new virtual functioncanPropagate(ConnectionId), and another functionpropagate(NodeId)to request a propagation without having to update connections or input/output. The user can also changeonOutPortDataUpdatedandpropagateEmptyDataTowith deriviative functions to change the output of the propagation for each connection.These functions are both virtual so that derivative dataflow models can specify their own control model, but this may go against the design of
DataFlowGraphModel. Feel free to deny or change as you wish. As an example:My project has nodes of text data ranging in the gigabytes. I use a global execution state to control when data is propagated and clone node outputs when there is more than one connection stemming from an output. This can be achieved with custom functions: