Repository navigation
Fix Issue 1787 "The specified Visual is not an ancestor of this Visual" exception - #1789
Conversation
VisualMelon
left a comment
VisualMelon
left a comment
There was a problem hiding this comment.
Thanks!
Just missing documentation on one of the methods.
I'll do a proper function check tonight/tomorrow when I have time, and then give it a couple of days before merging should the other maintainers spot something.
There was a problem hiding this comment.
Missing inline doc (per the PlotView version)
There was a problem hiding this comment.
I've omitted the documentation in OxySkElement, because there's nothing documented in the whole file. But I can add it.
There was a problem hiding this comment.
I hadn't realised; I suppose that's because it's a C&P of the provision by SkiaSharp. It would be nice to include it, given it is a divergence from the 'original' (indeed, we should consider documenting the whole file at some point).
Jonarw
left a comment
Jonarw
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this issue!
I don't mind the lack of documentation in OxySKElement - as you said, this whole class is mostly a workaround, ideally this would be fixed on SkiaSharp side. (Or we may even be able to get rid of the SKElement completely in the future as it is just another container).
3 participants
Fixes #1787.
Checklist
Changes proposed in this pull request:
My changes has a duplication of GetAncestorWindowFromVisualTree() in OxySKElement, but I think this is only a workaround, this should be fixed in the original SkiaSharp SKElement.
@oxyplot/admins