iframe-proxy

objorke · 2019-10-27T10:40:48Z

this is a preview for #1081

objorke · 2019-10-29T16:59:42Z

+            var rnd = new Random();
+            _ = WaitThenChangeColorAndToolTip(plot, rnd, fs);
+
+            plot.MouseDown += (s, e) =>


can these examples be implemented with the PlotController instead? #111

@VisualMelon I am not sure how to do this. My first impression is to use the extension method IController.BindMouseDown with a parameter of type DelegateViewCommand but I do not know how code-gen handles this, and, more important to me, I do not know what IController method to use instead of the model's MouseUp event.

Thank you.

I'm not sure, I've never used them myself. However, take a look at ManipulatorBase: you should be able to bind a MouseDownGesture, and implement the started/delta/completed events to handle the entire interaction.

@VisualMelon I posted my unsuccessful attempt on this in a gist. The relevant lines with comments are here. I think I will try more tomorrow. (I think that I must also find how to use the OxyMouseDownGesture class). It would be great if you could help me more. Thank you for all the help.

Manipulators are, I believe, a transient thing. Lots of examples in PlotCommands.cs (e.g. PanAt. I'd expect the code to be more like this:

plot.PlotView.ActualController.BindMouseDown(OxyMouseButton.Left, OxyModifierKeys.None, new DelegateViewCommand<OxyMouseDownEventArgs>((v, c, e) => { plot.PlotView.ActualController.AddMouseManipulator(plot.PlotView, new CustomMouseManipulator(v, rnd), e); }));

However, this can never work, because we just created the model, so it can't have a plotview or controller, so my gut feeling is that answer to @objorke question is that it is not possible. I think I'm going to have to try to get my head around #111...

objorke · 2019-10-29T17:02:19Z

        /// <param name="updateData">The update Data.</param>
        public void InvalidatePlot(bool updateData = true)
        {
+            if (this.ActualWidth <= 0 || this.ActualHeight <= 0)


I think this should be reverted

objorke · 2019-10-29T17:03:40Z

        /// </returns>
        protected override HitTestResult HitTestOverride(HitTestArguments args)
        {
+            if (!this.PlotModel.PlotArea.Contains(args.Point))


move this into calling method?

@VisualMelon Please, can you tell me how can I access the (PlotModel.)PlotArea from the calling method of the code above, UIElement.HitTest? Should there be a new UIElement.PlotModel property? Thank you.

I'm not sure. UIElement.PlotModel would couple UIElement to PlotModel unnecessarily. I'm not sure if objorke means that the decision to test agains the PlotArea should be handled higher up (though currently it cannot, because Model and not PlotModel do the work), or if the idea is just to reduce redundancy.

I am not totally convinced that the elements should be filtered at this layer, and I wonder if Model.HitTest should give more control to the inheriting class. That's all assuming the change is desirable, which I don't think is entirely clear with annotations.

objorke · 2019-10-29T17:32:59Z

Can we remove https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot/Rendering/RenderContext/IRenderContext.cs#L187 with these changes?

objorke · 2019-10-29T17:37:04Z

+        /// Shows the tooltip.
+        /// </summary>
+        /// <param name="str">The string to show as tooltip.</param>
+        void ShowToolTip(string str);


Wouldn´t it be simpler if this was in https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot/Graphics/IView.cs instead?

@objorke I do not have a strong opinion on this. I think that:

there are some configuration variables in IToolTipView that would pollute IView implementations

loosely coupled objects are good on the long term

Thank you.

silviubogan · 2019-10-31T08:33:16Z

@objorke

Can we remove https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot/Rendering/RenderContext/IRenderContext.cs#L187 with these changes?

It is done in a new commit: 192c643.

Thank you.

silviubogan · 2019-11-01T10:05:15Z

@VisualMelon A few unimportant questions, only if you have time for them:

What should be the order of the priorities of the tooltip string, the tooltip formatter and the tooltip format string? I would do it like this but I am not sure how good this is: if the tooltip string is available, take it, else if the tooltip format string is available take it, else take the tooltip formatter.
What variables should be passed to the format string if they should be? Currently the HitTestResult object is passed to the tooltip formatter. I think that in the next week I will take a better look at how this is done for the tracker format string.
If it is the case, is it possible to do a rebase onto upstream/develop without removing the existing comments on GitHub?

Thank you.

VisualMelon · 2019-11-01T13:42:09Z

@silviubogan

I'd go with (in preferential order) Formatter, Format String, just the String. I think that's what is done elsewhere.
I'm not sure. I'd forgotten the tracker was handled per-element, otherwise that would have been my suggestion. I might have another look later when I have more time.
Sorry, I don't know. I'd expect they just become 'outdated', but couldn't say for sure.

trovialdo · 2019-11-01T21:22:20Z

I'm wondering if we can just drop the ToolTip string property all together and only provide the formatter function and string. I do not think you would lose any functionality, you can also use the format string to show a static message (or formatter function for that matter).

Be careful if you want to pass more arguments to the formatter function since, if you do it like the tracker (possible custom # arguments per element), it will become the responsibility of the element to generate the tooltip. Hence you might need to add string GetToolTip(HitTestResult) on the element API, which i would try to avoid.

(and thanks for adding the formatter function!)

(whatever we decide upon we should do the same for the tracker to be consistent in API imo, so probably add a formatter function there as well. But this can be done later on and in another issue.)

+ improved a bit the code style + removed a piece of unused commented code

…Element)

+ left the toggle to on (the new tooltip system) and a few comments + removed a few lines of XAML

renamed a variable + improved some comments

removed a call in OxyPlot.Wpf to Dispatcher.BeginInvoke after testing without it

… based + improved a bit the code style

removed a few useless comments + dispose the ToolTip in OxyPlot.Wpf when the PlotView is disposed

…oolTip timing

improved XML comments in the two CustomToolTip classes

…lTip

solved some bugs about tooltip timing logic

…F and WinForms versions

…olTipController

…oller

CanvasRenderContext.currentToolTip

silviubogan · 2019-11-05T09:59:21Z

@VisualMelon In your opinion is it good to start working on a global tooltip functionality? What I want to say is a new property IPlotView.GlobalToolTip of type string that is shown, if it is not null, when the user moves the mouse over a portion of the plot that has no specific tooltip (e.g. a PlotElement that has no ToolTip(Formatter) set). Thank you.

Jonarw · 2023-07-11T08:01:42Z

silviubogan force-pushed the crossplatform-tooltip-system branch from c665f47 to 3c14084 Compare October 28, 2019 10:43

objorke commented Oct 29, 2019

View reviewed changes

silviubogan added 20 commits November 3, 2019 09:38

Work on WinForms tooltips

f5f062e

Added a few more comments

caf85f9

New & improved comments + work on WinForms tooltips

65d8f75

+ improved a bit the code style + removed a piece of unused commented code

Added a comment

d080018

Attempt to solve the issue

04a41bb

Work on custom tooltip system for OxyPlot.Wpf

7c8f080

Eliminated the empty visible tooltips, now I have duplicate tooltips

fa1d44c

Solved bug: duplicate tooltips (one after another when leaving a Plot…

e9e3dea

…Element)

Replaced old WPF tooltip system

4c6828c

+ left the toggle to on (the new tooltip system) and a few comments + removed a few lines of XAML

Made WinForms version work again

3394caa

Improved comment & solved bug: in WPF TitleToolTip not shown

07812cb

Improved an XML comment

cc2ba0a

Use default configuration for WinForms tooltips +

35278de

renamed a variable + improved some comments

Made the WinForms ExampleBrowser work well +

83c73e2

removed a call in OxyPlot.Wpf to Dispatcher.BeginInvoke after testing without it

Increased similarity between WinForms based tooltips code and the WPF…

6e74153

… based + improved a bit the code style

Exposed OxyToolTip properties in views (both WPF and WinForms) +

4b29665

removed a few useless comments + dispose the ToolTip in OxyPlot.Wpf when the PlotView is disposed

In the WPF custom tooltip system use ToolTipService.InitialShowDelay

78a9194

Implemented usage of all 3 ToolTipService attached properties about T…

629c4c4

…oolTip timing

More work on WinForms custom tooltip system

1ff6b02

Improved style in PlotView.cs in OxyPlot.WindowsForms

660e5c0

silviubogan added 24 commits November 3, 2019 09:38

New member: IToolTip.UsualPlotElementHitTestingTolerance +

903a6a9

improved XML comments in the two CustomToolTip classes

Improved XML comments, class ToolTippedPlotElement, classes CustomToo…

03f94fe

…lTip

Removed not well-thought changes to examples and demos

e42f1e6

Exposed the 3 native tooltip timing properties in IToolTip +

869c158

solved some bugs about tooltip timing logic

Remove useless changes in WPF-based PlotBase.cs

4625ac9

Added two identical XML comments

987e536

Made IToolTip implement IDisposable

b75e421

Improved some XML comments

1644d75

Removed redundant cancellation checks

ec3ff2a

Improve name of optional plot view c-tor tooltip parameter in both WP…

5f4510f

…F and WinForms versions

Improvements to code style in many files based on StyleCop analyzer

429fbc0

Start working on ToolTipController

8b7cab4

New WpfToolTipView class + better modularized code

b56bd0a

Finished the tooltips' controller logic

69b3755

Corrected some XML comments + improved code style

7e18122

Removed useless using

b1fb693

WPF PlotView.ToolTipController is now an IToolTipController, not a To…

5d75092

…olTipController

Dispose old IToolTipView when changing to another one in ToolTipContr…

533af34

…oller

Improved class ToolTippedPlotElement

ef2cb72

Removed GetClientScreenPointForMouse

3e49e78

Added three examples for tooltips

4ec103b

Revert first if statement in WPF PlotBase.InvalidatePlot method

9fc1293

Removed dead code including IRenderContext.SetToolTip +

2eb4839

CanvasRenderContext.currentToolTip

Implemented tooltip formatters, added relevant example

cb70700

silviubogan force-pushed the crossplatform-tooltip-system branch from 3c1d82e to cb70700 Compare November 3, 2019 07:40

This was referenced Nov 3, 2019

Crossplatform tooltip system #1418

Open

Hit testing for axes #1419

Open

Jonarw closed this Jul 11, 2023

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

objorke commented Oct 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VisualMelon Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VisualMelon Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

objorke commented Oct 29, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silviubogan commented Oct 31, 2019

Uh oh!

silviubogan commented Nov 1, 2019

Uh oh!

VisualMelon commented Nov 1, 2019

Uh oh!

trovialdo commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silviubogan commented Nov 5, 2019

Uh oh!

Jonarw commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VisualMelon Oct 31, 2019 •

edited

Loading

VisualMelon Oct 31, 2019 •

edited

Loading

trovialdo commented Nov 1, 2019 •

edited

Loading